search

maplibre / maplibre-gl-directions

A plugin to show routing directions on a MapLibre GL JS map
https://maplibre.org/maplibre-gl-directions/
MIT License
72 stars 16 forks source link

Preserve the "hover" state for waypoints after their creation and movement #234

Closed smellyshovel closed 1 month ago

smellyshovel commented 1 month ago

Closes #232.

smellyshovel commented 1 month ago

@joleeee a review is welcome.

joleeee commented 1 month ago

Hi, are there install instructions? .nvmrc says 16, but when i try to install with node 16 i get that a bunch of things require >=18.

smellyshovel commented 1 month ago

Hi, are there install instructions? .nvmrc says 16, but when i try to install with node 16 i get that a bunch of things require >=18.

Everything's documented in the CONTRIBUTING.md. Regarding the Node version - it easily may be so. The deps were updated a lot of times, but I haven't touched the .nvmrc, so it's probably outdated. Feel free to fix it.

joleeee commented 1 month ago

Definitely still some funky stuff going on (rev 84d66228df8884184e2136eaa7b95f63df030cbd)

https://github.com/user-attachments/assets/d26c6737-e26d-47a2-adab-ca3fe9623fb8

smellyshovel commented 1 month ago

Definitely still some funky stuff going on (rev 84d6622)

rec.mp4

Got it. Haven't tested with delayed responses. So, the 2 tickets you've created must be related somehow. Apparently, the interactivity gets disabled while there's an ongoing request, and this fix contradicts that. So, this will require a further look.

Closing this PR for now.