search

maplibre / maplibre-gl-geocoder

Geocoding for MapLibre
ISC License
45 stars 17 forks source link

add documentation for package dependencies if it is used in vite #111

Closed JinIgarashi closed 2 days ago

JinIgarashi commented 10 months ago

I had an error of TypeError: EventEmitter is not a constructor when I use it with vite.

I found the below stackoverflow, https://stackoverflow.com/questions/69717406/typeerror-eventemitter-is-not-a-constructor-at-new-mapboxgeocoder

then, I found the following dependencies are necessary to use this geocoder.

npm i -D events @types/events @types/node

I am not sure how many people are using vite with this geocoder, but this dependencies info can be documented somewhere in the repo. I think vite is becoming more popular.

HarelM commented 1 week ago

Feel free to submit a PR.

HarelM commented 4 days ago

This will probably be fixed by #118.