Closed thaddmt closed 2 years ago
Are we using package-lock.json
at all?
What are the breaking changes in nanoid v3?
Are we using
package-lock.json
at all?
Going to make a separate PR after this to use package-lock.json
. Was mostly using yarn before this but figure most of the other maplibre packages use NPM and we should follow suit here.
Nice. In GL JS we use nvm use 16
. Ideally we do the same here.
What are the breaking changes in nanoid v3?
Actually realized after looking into it more we removed the code that used nanoid
when we forked from mapbox-gl-geocoder so it is no longer needed :)
You are right, and there are more in the devDependencies:
➜ maplibre-gl-geocoder git:(main) npx depcheck
Unused dependencies
* nanoid
Unused devDependencies
* brfs
* browserify
* budo
* documentation
* envify
* eslint
* husky
* smokestack
* tap-color
* tap-status
* uglify-js
If you migrate package-lock.json
to v2, please also update the contributors guidelines and tell people to use nvm use 16
.
You are right, and there are more in the devDependencies:
➜ maplibre-gl-geocoder git:(main) npx depcheck Unused dependencies * nanoid Unused devDependencies * brfs * browserify * budo * documentation * envify * eslint * husky * smokestack * tap-color * tap-status * uglify-js
Yep! was planning to get to those also in a separate PR since I wanted to take more time to verify they aren't needed
Overview
npm run docs
and commit changes to API.mdmaster
heading before merging