Closed Cactusbone closed 2 years ago
Thanks for this. I think it would be good to have the test running in this repo on pull requests. Any chance to review #47 ?
When you update package.json
, please make sure to also run npm install
such that the changes are reflected in package-lock.json
.
At the moment, I get the following diff:
diff --git a/package-lock.json b/package-lock.json
index 0faa298..14875db 100644
--- a/package-lock.json
+++ b/package-lock.json
@@ -1,12 +1,12 @@
{
"name": "@maplibre/maplibre-gl-geocoder",
- "version": "1.3.0",
+ "version": "1.3.1",
"lockfileVersion": 2,
"requires": true,
"packages": {
"": {
"name": "@maplibre/maplibre-gl-geocoder",
- "version": "1.3.0",
+ "version": "1.3.1",
"license": "ISC",
"dependencies": {
"lodash.debounce": "^4.0.6",
@@ -38,7 +38,7 @@
"node": ">=6"
},
"peerDependencies": {
- "maplibre-gl": "^1.14.0"
+ "maplibre-gl": ">=1.14.0"
}
},
"node_modules/@babel/code-frame": {
The part about the plugin version 1.3.1
is related to the fact that we forgot to run npm install
at the last version bump.
ha yeah, forgot this file. saw your PR https://github.com/maplibre/maplibre-gl-geocoder/pull/45 too :)
I've rebased to enable CI :)
Just to double-check, you tried this out with MapLibre GL JS v2.1.8?
Just to double-check, you tried this out with MapLibre GL JS v2.1.8?
I tried with 2.1.6 :)
Code is very similar to https://maplibre.org/maplibre-gl-js-docs/example/geocoder/ which seems to use v2.1.7
This accepts maplibre-gl v2 as a peer dependency.
npm run docs
and commit changes to API.mdmaster
heading before merging