issues
search
maplibre
/
maplibre-gl-geocoder
Geocoding for MapLibre
ISC License
45
stars
17
forks
source link
fix: fix bug with fitbounds array, fix bug where clearbutton doesnt show up after pressing enter
#79
Closed
thaddmt
closed
2 years ago
thaddmt
commented
2 years ago
fitBounds throws an error with certain versions of maplibre-gl typescript due to type error with LngLatBoundsLike, fixed this error by just passing in an array of bounds instead of a LngLatBoundsLike object
After
https://github.com/maplibre/maplibre-gl-geocoder/pull/72
the clearButton was not showing up because the logic was defined as only showing up if there is a
selected
target
Updated logic to show the clear button if there is any value in the inputElement field
added unit tests that verify the clear button shows up
[x] briefly describe the changes in this PR
[x] write tests for all new functionality
[ ] run
npm run docs
and commit changes to API.md
[ ] update CHANGELOG.md with changes under
main
heading before merging
selected
targetnpm run docs
and commit changes to API.mdmain
heading before merging