search

maplibre / maplibre-gl-js

MapLibre GL JS - Interactive vector tile maps in the browser
https://maplibre.org/maplibre-gl-js/docs/
Other
6.1k stars 667 forks source link

Heatmap not working #1081

Open prozessor13 opened 2 years ago

prozessor13 commented 2 years ago

There exists already a discussion about that: https://github.com/prozessor13/maplibre-gl-js/issues/46

HarelM commented 1 year ago

@acalcutt @prozessor13 does this issue still exists?

acalcutt commented 1 year ago

It works fine without terrain enabled and no longer gives an error, but heatmap still doesn't work right with terrain enabled.

Heres an example page https://stackblitz.com/edit/web-platform-c7xcln?file=index.html

In this example initially terrain is off and the heatmap looks fine. If you change the pitch is still looks ok. However if you enable terrain and try to change the pitch. you can see the heatmap kind of floats and isn't really in the correct place.

prozessor13 commented 1 year ago

Heatmap is still an open issue in terrain, and i think i will not find time to fix this in the near future. sorry! If someone is motivated to implement it, i can act as a sparring partner.

HarelM commented 1 year ago

Assigned M bounty. Link to parent Bounty: https://github.com/maplibre/maplibre/issues/189

tempranova commented 1 year ago

Hey there, I'm willing to take this one on!

HarelM commented 1 year ago

Enjoy!

tempranova commented 1 year ago

Unfortunately, after messing around with this a whole bunch, I think it's beyond my current understanding of how the library works! I'll have to ask to be unassigned from this one for now until I have some more experience. Apologies!

HarelM commented 1 year ago

No problem. Thanks for trying!

HarelM commented 1 year ago

There are some bounties related to writing tests for PRs that are missing tests but have new and good functionality, writing these unit tests should be fairly technical and shouldn't be too complicated. It would be great if you could help there, it will also push forward the release of 3.0.

dipakpatil1509 commented 1 month ago

Hey @HarelM, I would be glad to work on this issue. Can you please assign this issue to me?

HarelM commented 1 month ago

Done. Good luck!