FoV has a hardcoded value in FlyTo

maplibre / maplibre-gl-js

MapLibre GL JS - Interactive vector tile maps in the browser

https://maplibre.org/maplibre-gl-js/docs/

Other

6.76k stars 730 forks source link

FoV has a hardcoded value in FlyTo #5078

Open AbelVM opened 1 week ago

AbelVM commented 1 week ago

Now that the FoV can be arbitrarily set up by the user, we should change the code block at https://github.com/maplibre/maplibre-gl-js/blob/main/src/ui/camera.ts#L1471-L1475 to reflect that, instead of being fixed to 53º.

HarelM commented 1 week ago

Any chance you could open a PR for this?

AbelVM commented 1 week ago

Based on https://vanwijk.win.tue.nl/zoompan.pdf , looks like the issue is related to the comment, not the code. But I can't be sure as this function is a bit of a rabbit hole for me right now.

I'm digging into it to take https://github.com/maplibre/maplibre-gl-js/issues/116 back into life with the new tiles logic

HarelM commented 1 week ago

Since the addition of editing FoV was just added recently, I'll bet that the comment is no longer up to date...