maplibre / maplibre-gl-leaflet

This is a binding from MapLibre GL JS to the familiar Leaflet API.
ISC License
134 stars 36 forks source link

Add publish workflow, bump version #12

Closed wipfli closed 3 years ago

wipfli commented 3 years ago

This pull request adds the publish.yml github action workflow which publishes maplibre-gl-leaflet to NPM on manual trigger.

secrets.NODE_AUTH_TOKEN stores a npmjs.com access token that is associated with my account (https://www.npmjs.com/~wipfli). @nyurik please add me to the maplibre organization.

wipfli commented 3 years ago

@HarelM

HarelM commented 3 years ago

I prefer that the trigger will be creating a github tag so that github will all have the versions in the releases in github as can be seen here: https://github.com/maplibre/ngx-maplibre-gl/blob/master/.github/workflows/npm-publish.yml But it's subjective.

Have we decided to use @ maplibre for npm packages? If so, we probably need to change the other packages as well.

Other than that, good job! :-)

wipfli commented 3 years ago

Thanks for reviewing. Yes, we decided with @nyurik to use @maplibre/<package-name>, see https://www.npmjs.com/package/@maplibre/maplibre-gl-style-spec for example which is defined here https://github.com/maplibre/maplibre-gl-js/blob/36647c018f41222e8af45d34ba79e3b6f14d570a/src/style-spec/package.json#L2

wipfli commented 3 years ago

https://github.com/maplibre/maplibre-gl-js/pull/149

HarelM commented 3 years ago

There's a question about maplibre-gl npm package itself, doesn't it? :-)

wipfli commented 3 years ago

Right, I asked Yuri the same question. Fortunately, we can stand on the shoulders of mapbox:

https://www.npmjs.com/package/mapbox-gl

HarelM commented 3 years ago

I like better the angular way where all packages has the same "company/project" prefix. But I might be in the minority. I tend to think that mapbox-gl was probably the first one (like angularjs), and only later on the rest were added and were prefixed, but I don't know, it might be just a hunch. I'm not sure if it's open for discussion, but I prefer that every npm package would be under @ maplibre including the "main" one...

wipfli commented 3 years ago

I would prefer @maplibre/maplibre-gl too. Can you open an issue on the GL JS repo?