search

maplibre / maplibre-native-qt

MapLibre Qt Bindings and Qt Location Plugin
33 stars 12 forks source link

Tag new release #92

Open rinigus opened 6 months ago

rinigus commented 6 months ago

As v2.1.0 cannot be used with Qt5, would you mind to tag current state as a new release? I have used 85673cbe94d6ec0d9e7a35952375c24cb5f51589 for testing on Sailfish OS and it looks to be working fine. Had to adjust QML bindings (https://github.com/rinigus/mapbox-gl-qml) for updated API, but that seemed to work without any issues. Would be great to release updated libs stack for use on mobile Linux platforms.

ntadej commented 6 months ago

Interesting, I use v2.1.0 in production Qt5-based apps.

I will tag v3 as soon as I get the automated builds for Windows running (in the next few days).

rinigus commented 6 months ago

I wonder if you are using qmake then. As I don't see how the following line can work in the systems without Qt6:

https://github.com/maplibre/maplibre-native-qt/blob/57bf1a38ac12023d9454d27aebba7604d357d2ad/CMakeLists.txt#L15

ntadej commented 6 months ago

Yes, Qt5 build of v2 needs to be built with qmake.

rinigus commented 6 months ago

OK, so that was a lost functionality when compared to building maplibre-native. I guess I will wait for new release instead of changing building scripts for SFOS