maplibre / maplibre-native

MapLibre Native - Interactive vector tile maps for iOS, Android and other platforms.
https://maplibre.org
BSD 2-Clause "Simplified" License
1.03k stars 299 forks source link

Android CamerUpdateFacotry#zoomOut regression #1017

Closed boldtrn closed 1 year ago

boldtrn commented 1 year ago

Describe the bug Zoom out leads to zooming to z0.

I think this should be max not min: https://github.com/maplibre/maplibre-gl-native/blob/4828cc7a8be58579b4a2beed8033fefc2fda5170/platform/android/MapboxGLAndroidSDK/src/main/java/com/mapbox/mapboxsdk/camera/CameraUpdateFactory.kt#L451

Quickfix for users would be: CameraUpdateFactory.zoomBy(-1.0)

artakka commented 1 year ago

Good catch

ovivoda commented 1 year ago

@boldtrn feel free to create a PR for this!

boldtrn commented 1 year ago

I created a PR for this: https://github.com/maplibre/maplibre-gl-native/pull/1035