search

maplibre / maplibre-native

MapLibre Native - Interactive vector tile maps for iOS, Android and other platforms.
https://maplibre.org
BSD 2-Clause "Simplified" License
989 stars 292 forks source link

Fix flakiness Android Instrumentation Tests #2248

Open louwers opened 4 months ago

louwers commented 4 months ago

I would like to run the Android instrumentation tests as part of the PR workflows.

There are some flakiness issues.

  1. https://github.com/maplibre/maplibre-native/issues/2187

  2. This happens sometimes:

java.lang.IllegalArgumentException: Could not find layer Streets
at org.maplibre.android.maps.Style.getPredefinedStyle(Style.java:1430)
at org.maplibre.android.testapp.activity.espresso.PixelTestActivity.onMapReady(PixelTestActivity.kt:29)
  1. Precision when comparing floats should be reduced in a few places.
kocheick commented 4 months ago

I'm experimenting the same error as I'm looking to update the plugins from maplibre-android-plugins repository to use MapLibre instead of Mapbox. Most (99%) of the code/packages have been renamed to MapLibre but when I run the Tests to make sure all is well: many tests pass fine but some throw this particular exception : java.lang.IllegalArgumentException: Could not find layer Streets