maplibre / maplibre-native

MapLibre Native - Interactive vector tile maps for iOS, Android and other platforms.
https://maplibre.org
BSD 2-Clause "Simplified" License
925 stars 280 forks source link

Change naming in some platform files #2452

Closed TimSylvester closed 1 month ago

TimSylvester commented 1 month ago

Eliminates some additional vestiges of Mapbox.

Fixes a problem with debug tile outlines caused by each source clearing debug drawables from previous sources. This appeared because the change from "com.mapbox" to "org.maplibre" makes the annotation source appear after the "maplibre" source specified in the test stylesheet. Note that this will cause multiple debug features to appear when the same tiles are rendered from multiple sources.

Also fixes missing UBO binding on polyline debug outlines. This was probably working only because the UBO isn't ever accessed (expressions aren't used in debug drawables), and the error only appears with Metal validation enabled.

github-actions[bot] commented 1 month ago

Bloaty Results (iOS) 🐋

Compared to main

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  [ = ]       0  [ = ]       0    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results-ios/pr-2452-compared-to-main.txt

github-actions[bot] commented 1 month ago

Bloaty Results 🐋

Compared to main

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.0% +3.52Ki  +0.0% +2.42Ki    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results/pr-2452-compared-to-main.txt

Compared to d38709084a9865fe0bb8300aec70ebf8243b3d43 (legacy)

    FILE SIZE        VM SIZE    
 --------------  -------------- 
   +21% +24.1Mi  +409% +24.4Mi    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results/pr-2452-compared-to-legacy.txt

github-actions[bot] commented 1 month ago

Benchmark Results ⚡

Benchmark                                                     Time             CPU      Time Old      Time New       CPU Old       CPU New
------------------------------------------------------------------------------------------------------------------------------------------
OVERALL_GEOMEAN                                            +0.0015         +0.0014             0             0             0             0

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/benchmark-results/pr-2452-compared-to-main.txt