maplibre / maplibre-native

MapLibre Native - Interactive vector tile maps for iOS, Android and other platforms.
https://maplibre.org
BSD 2-Clause "Simplified" License
898 stars 274 forks source link

Do not interpolate zoom during flyTo when start and end zoom are same #2479

Open louwers opened 1 month ago

louwers commented 1 month ago

When using flyTo zoom should not be interpolated during the transition. This was causing flickering of labels. Fixes https://github.com/maplibre/maplibre-native/issues/2477

https://github.com/maplibre/maplibre-native/assets/649392/e8306a18-2da7-4dac-b546-66ee73bd30b3

louwers commented 1 month ago

Oops, this defeats the purpose of the flyTo algorithm. I hope the tests fail otherwise we need to add some test coverage for it.

Will look for another way to fix the problem.

github-actions[bot] commented 1 month ago

Bloaty Results (iOS) 🐋

Compared to main

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  [ = ]       0  [ = ]       0    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results-ios/pr-2479-compared-to-main.txt

github-actions[bot] commented 1 month ago

Bloaty Results 🐋

Compared to main

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.0%    +216  +0.0%     +24    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results/pr-2479-compared-to-main.txt

Compared to d38709084a9865fe0bb8300aec70ebf8243b3d43 (legacy)

    FILE SIZE        VM SIZE    
 --------------  -------------- 
   +21% +24.1Mi  +409% +24.4Mi    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results/pr-2479-compared-to-legacy.txt

github-actions[bot] commented 1 month ago

Benchmark Results ⚡

Benchmark                                                     Time             CPU      Time Old      Time New       CPU Old       CPU New
------------------------------------------------------------------------------------------------------------------------------------------
OVERALL_GEOMEAN                                            -0.0011         -0.0011             0             0             0             0

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/benchmark-results/pr-2479-compared-to-main.txt