maplibre / maplibre-native

MapLibre Native - Interactive vector tile maps for iOS, Android and other platforms.
https://maplibre.org
BSD 2-Clause "Simplified" License
898 stars 274 forks source link

Formatting Objective-C and Objective-C++ #2492

Closed louwers closed 3 weeks ago

louwers commented 3 weeks ago

Include Objective-C and Objective-C++ in clang-format formatting. Automatically enforced (and applied) on CI.

Changes are minimal in most files.

The only change I made to the default Google style is:

ObjCSpaceAfterProperty: true

so we have

@property (nonatomic, copy, nullable)

instead of

@property(nonatomic, copy, nullable)

~I removed the "check-public-symbol" script. It didn't account for MLN_EXPORT being on another line that is split. However, this script has little value, because it checks for the debug symbols in Mapbox.h. This umbrella header is only included for backward compatibility. The auto-generated MapLibre.h umbrella header should be used.~

Never mind, we still need that, it just needs to also check the auto-generated header. I am making sure MLN_EXPORT works and that the script is updated.

github-actions[bot] commented 3 weeks ago

Bloaty Results (iOS) 🐋

Compared to main

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  [ = ]       0  [ = ]       0    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results-ios/pr-2492-compared-to-main.txt

github-actions[bot] commented 3 weeks ago

Bloaty Results 🐋

Compared to main

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  [ = ]       0  [ = ]       0    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results/pr-2492-compared-to-main.txt

Compared to d38709084a9865fe0bb8300aec70ebf8243b3d43 (legacy)

    FILE SIZE        VM SIZE    
 --------------  -------------- 
   +21% +24.1Mi  +409% +24.4Mi    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results/pr-2492-compared-to-legacy.txt

github-actions[bot] commented 3 weeks ago

Benchmark Results ⚡

Benchmark                                                     Time             CPU      Time Old      Time New       CPU Old       CPU New
------------------------------------------------------------------------------------------------------------------------------------------
OVERALL_GEOMEAN                                            +0.0095         +0.0098             0             0             0             0

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/benchmark-results/pr-2492-compared-to-main.txt