search

maplibre / maplibre-native

MapLibre Native - Interactive vector tile maps for iOS, Android and other platforms.
https://maplibre.org
BSD 2-Clause "Simplified" License
1.03k stars 300 forks source link

attribution button action sheet links do not work #2574

Closed baubrey91 closed 2 months ago

baubrey91 commented 3 months ago

Describe the bug Links in attributionButton action sheet do not take users to webview link, they just dismiss the action sheet.

To Reproduce Steps to reproduce the behavior:

  1. Go to mapview configured with a urlstyle json or hardcoded attribution style
  2. Click on attribution button on bottom right
  3. Click on copyright link
  4. User is not taken to website of copyrighted library

Expected behavior User is taken to webview

ScreenShot
Simulator Screenshot - iPhone 15 Pro - 2024-07-03 at 16 47 49

Video https://github.com/maplibre/maplibre-native/assets/5482416/c74e3099-5a32-4f32-a278-2eaa6ae6f382

Platform information (please complete the following information):

Additional context It looks like this issue started in 5.12 as a pr was made that removed the assignment of calling the webview in the callback when creating the action sheet. See PR Additionally it looks like there was another pr that re-added the logic to show the text but not have the link action see PR

louwers commented 3 months ago

Thanks a lot for the report. Is this something you would be comfortable fixing? A PR would be highly welcomed.

We're not updating the 5.x.x release series for iOS anymore, so I hope updating to 6.x.x (with Metal support) is an option for you.

baubrey91 commented 2 months ago

Thanks a lot for the report. Is this something you would be comfortable fixing? A PR would be highly welcomed.

We're not updating the 5.x.x release series for iOS anymore, so I hope updating to 6.x.x (with Metal support) is an option for you.

PR made https://github.com/maplibre/maplibre-native/pull/2587

louwers commented 2 months ago

This will be included in the next version.