maplibre / maplibre-native

MapLibre Native - Interactive vector tile maps for iOS, Android and other platforms.
https://maplibre.org
BSD 2-Clause "Simplified" License
1.04k stars 300 forks source link

Add Android Vulkan backend #2711

Closed adrian-cojocaru closed 4 weeks ago

adrian-cojocaru commented 1 month ago
github-actions[bot] commented 1 month ago

Bloaty Results (iOS) 🐋

Compared to main

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  [ = ]       0  [ = ]       0    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results-ios/pr-2711-compared-to-main.txt

github-actions[bot] commented 1 month ago

Bloaty Results 🐋

Compared to main

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  -0.0%      -8  -0.0%     -40    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results/pr-2711-compared-to-main.txt

Compared to d38709084a9865fe0bb8300aec70ebf8243b3d43 (legacy)

    FILE SIZE        VM SIZE    
 --------------  -------------- 
   +27% +31.6Mi  +422% +25.2Mi    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results/pr-2711-compared-to-legacy.txt

github-actions[bot] commented 1 month ago

Benchmark Results ⚡

Benchmark                                                     Time             CPU      Time Old      Time New       CPU Old       CPU New
------------------------------------------------------------------------------------------------------------------------------------------
OVERALL_GEOMEAN                                            -0.0091         -0.0097             0             0             0             0

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/benchmark-results/pr-2711-compared-to-main.txt

louwers commented 1 month ago

pre-commit.ci run

mwilsnd commented 1 month ago

Screenshot_2024-08-30-16-16-59-33_761d22eebee04fe0b23bb040358a6eab The viewport rotates clockwise 90 degrees when I run it on the inside screen of my foldable. Touch controls still function as if the map wasn't rotated though.

sjg-wdw commented 1 month ago

Screenshot_2024-08-30-16-16-59-33_761d22eebee04fe0b23bb040358a6eab The viewport rotates clockwise 90 degrees when I run it on the inside screen of my foldable. Touch controls still function as if the map wasn't rotated though.

My proposal is if the user rotates on Android we just pop up a little window that says 'No' until they rotate back.

adrian-cojocaru commented 1 month ago

@mwilsnd The rotation should be fixed. This was due to my incomplete implementation of a surface pre-rotation. Leaving it to the Android compositor for now.

louwers commented 1 month ago

Maybe @alexcristici and @TimSylvester can have a final look over this.

I think all conversations can be resolved and we can merge this.