Closed adrian-cojocaru closed 4 weeks ago
Compared to main
FILE SIZE VM SIZE
-------------- --------------
[ = ] 0 [ = ] 0 TOTAL
Compared to main
FILE SIZE VM SIZE
-------------- --------------
-0.0% -8 -0.0% -40 TOTAL
Compared to d38709084a9865fe0bb8300aec70ebf8243b3d43 (legacy)
FILE SIZE VM SIZE
-------------- --------------
+27% +31.6Mi +422% +25.2Mi TOTAL
Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results/pr-2711-compared-to-legacy.txt
Benchmark Results ⚡
Benchmark Time CPU Time Old Time New CPU Old CPU New
------------------------------------------------------------------------------------------------------------------------------------------
OVERALL_GEOMEAN -0.0091 -0.0097 0 0 0 0
Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/benchmark-results/pr-2711-compared-to-main.txt
pre-commit.ci run
The viewport rotates clockwise 90 degrees when I run it on the inside screen of my foldable. Touch controls still function as if the map wasn't rotated though.
The viewport rotates clockwise 90 degrees when I run it on the inside screen of my foldable. Touch controls still function as if the map wasn't rotated though.
My proposal is if the user rotates on Android we just pop up a little window that says 'No' until they rotate back.
@mwilsnd The rotation should be fixed. This was due to my incomplete implementation of a surface pre-rotation. Leaving it to the Android compositor for now.
Maybe @alexcristici and @TimSylvester can have a final look over this.
I think all conversations can be resolved and we can merge this.
sourceSets
forMapRenderer
and Surface/Texture views