Remove support for MapBox API keys

maplibre / maplibre-native

MapLibre Native - Interactive vector tile maps for iOS, Android and other platforms.

https://maplibre.org

BSD 2-Clause "Simplified" License

1.08k stars 319 forks source link

Remove support for MapBox API keys #349

Open ntadej opened 2 years ago

ntadej commented 2 years ago

Remove support for MapBox API keys similar to what was done in JS.

wipfli commented 2 years ago

I put it on the agenda of the meeting on July, 13th, 2022.

rinigus commented 2 years ago

Why there is a need to remove MapBox API keys support? I would like to keep an option to use them for users that prefer MapBox as a map tile provider.

ntadej commented 2 years ago

After some thought the proposed plan is the following:

make it clear that MapLibre is provider agnostic
add ability to simply add a mapping provider
keep MapBox and MapTiler support in but move it in a special location to collect "3rd party" providers so nothing will change for end users for now (but this may cause a minor client API change)

wipfli commented 2 years ago

This was the gl js discussion https://github.com/maplibre/maplibre-gl-js/discussions/290

rinigus commented 2 years ago

I don't see in that discussion (https://github.com/maplibre/maplibre-gl-js/discussions/290#discussioncomment-1317680) specific legal statement that precludes use of Mapbox tiles through some other library. We use REST API anyway. If some removal is going to happen, please provide instructions on how to get it back. As far as I remember, Mapbox is using mapbox:// URI scheme in their styles. So, we would need then to somehow interact with Qt http and Curl http loaders (latter is used in Pure Maps due to bugs in Qt 5.6 preventing offline usage of qt http loader).

wipfli commented 2 years ago

I think providing an easy migration path is a good idea.