search

maplibre / maplibre-navigation-android

Maplibre Navigation SDK for Android
MIT License
86 stars 44 forks source link

Update dependencies #109

Closed Fabi755 closed 2 months ago

Fabi755 commented 3 months ago

Update dependencies to latest versions.

MapLibre is updated to the latest 10.x.x version.

Part of #104.

boldtrn commented 3 months ago

Thanks for working on this @Fabi755.

I just tried to build this version on Jitpack, but this failed: https://jitpack.io/com/github/Fabi755/maplibre-navigation-android/5a33e1d93e/build.log

The issue might be the java version? https://github.com/maplibre/maplibre-navigation-android/blob/main/jitpack.yml

Otherwise, I haven't seen other issues yet, but I haven't been able to test the PR yet due to that.

boldtrn commented 3 months ago

Thank you very much for working on this. I gave this another try. The Jitpack build works fine 👍.

I tried to implement this in a demo project and in the demo project that is using your dependency, some dependencies can't be resolved anymore, in particular: import com.mapbox.geojson.* (the whole geojson namespace)

I think this is resolved through the turf dependency here: https://github.com/maplibre/maplibre-navigation-android/blob/0c4c017e613abcf6bd12ba2e930d771e073dbf3c/libandroid-navigation/build.gradle#L59C26-L59C38

For some reason seems to be not working anymore. Do you have any idea what might be the reason for this?

Fabi755 commented 3 months ago

I fixed the Maven publishing, and try it out with local repo and the test app. Seems to working now.

I can't test the Jitpack publishing yet, while the server can not reach the Internet (what?!?! :raised_eyebrow:)

==== INTERNET NOT REACHABLE! =================================================== https://jitpack.io/com/github/fabi755/maplibre-navigation-android/0b105369a7/build.log

I will retry this tomorrow and hope it will work then.

Fabi755 commented 3 months ago

The latest commit has build now.

Adding the library via

implementation 'com.github.Fabi755.maplibre-navigation-android:libandroid-navigation-ui:3aed0f309c'

is working for me. Let me know, if you found again some issue.