maplibre / maplibre-navigation-android

Maplibre Navigation SDK for Android
MIT License
92 stars 51 forks source link

Update gms location dependency #33

Closed boldtrn closed 1 year ago

boldtrn commented 1 year ago

The current dependency com.google.android.gms:play-services-location:16.0.0 is quite old, we should update this dependency.

I tried this, but somehow it did not work. Not sure where this comes from 'com.google.android.gms:play-services-location:{strictly 16.0.0}' because of the following reason: debugRuntimeClasspath uses version 16.0.0, when you change 16.0.0 to 21.0.1 there is no v16 defined in the project anymore.

FAILURE: Build failed with an exception.
* What went wrong:
Execution failed for task ':libandroid-navigation:generateDebugRFile'.
> Could not resolve all files for configuration ':libandroid-navigation:debugCompileClasspath'.
   > Could not resolve com.google.android.gms:play-services-location:21.0.1.
     Required by:
         project :libandroid-navigation
      > Cannot find a version of 'com.google.android.gms:play-services-location' that satisfies the version constraints:
           Dependency path 'com.mapbox.mapboxsdk:libandroid-navigation:1.0.3' --> 'com.google.android.gms:play-services-location:21.0.1'
           Constraint path 'com.mapbox.mapboxsdk:libandroid-navigation:1.0.3' --> 'com.google.android.gms:play-services-location:{strictly 16.0.0}' because of the following reason: debugRuntimeClasspath uses version 16.0.0
boldtrn commented 1 year ago

After some more investigation, it seems that we get v16 from the upstream maplibre-sdk, we should probably update the version upstream.

boldtrn commented 1 year ago

This has been fixed upstream, once there is a new release, we can update this lib here as well.

Ref: https://github.com/maplibre/maplibre-gl-native/pull/627