maplibre / maplibre-navigation-android

Maplibre Navigation SDK for Android
MIT License
87 stars 45 forks source link

Improve extendability of NavigationMapRoute #36

Closed boldtrn closed 1 year ago

boldtrn commented 1 year ago

The methods initialize and addListeners are called in the constructor of NavigationMapRoute. It should be possible to extend them and change how they work.

In the long run, we should probably consider moving most of the private properties to protected, as this class is responsible for the styling of the navigation experience and clients probably want to change how their apps look without too much trouble.

frankkienl commented 1 year ago

I agree protected can be better than private in certain cases. That way people can change these methods when extending the class 👍

Changing methods from private to protected, could also mean having to change some documentation. So let's keep that in mind as well 😉 !

boldtrn commented 1 year ago

Changing methods from private to protected, could also mean having to change some documentation. So let's keep that in mind as well 😉 !

Do you want me to change something here? We could mention it in the changelog, it is a small change, but could be worth mentioning?

boldtrn commented 1 year ago

@Brammos thanks for the review, I reverted the icon pitch change.

boldtrn commented 1 year ago

@Brammos, are you fine with this PR or should I change something?