search

maplibre / maplibre-navigation-android

Maplibre Navigation SDK for Android
MIT License
86 stars 44 forks source link

Improve route snap engine #77

Closed Fabi755 closed 1 year ago

Fabi755 commented 1 year ago

Improve logic of route snap logic and support bearing for multiple legs

Closes #74

boldtrn commented 1 year ago

From my point of view we can merge this. Just one note, the Snapping is very critical for performance as the snap happens once every second. So this code influence battery usage quite dramatically. I don't think there is a big impact compared to the previous code, but if you see any options to improve this, please let me know :).

Fabi755 commented 1 year ago

I removed a unused function and improve the point validation performance. I don't see something more to adjust the performance.

From my side we can merge this.

boldtrn commented 1 year ago

Thanks a lot for the great PR 👍