search

maplibre / maplibre-navigation-android

Maplibre Navigation SDK for Android
MIT License
86 stars 44 forks source link

Fix rerouting not take effect on off route event. #81

Closed tallongsun closed 11 months ago

tallongsun commented 11 months ago

Think the progress variable here should be the method parameter routeProgress rather than class member variable this.routeProgress. When buildRequest() is called by findRouteFromRouteProgress(), this.routeProgress = routeProgress. However when it is called by findRouteFrom(), this.routeProgress is not assigned. So when rerouting occurs on off route event, it doesn't take effect.

boldtrn commented 11 months ago

Thanks for catching this. Could you rebase your changes onto the current main, as your commit history seems wrong. It should only contain this commit: https://github.com/maplibre/maplibre-navigation-android/pull/81/commits/7cae144df35e17cd7a32ba6a1da6c751e81f2010

tallongsun commented 11 months ago

@boldtrn Done