SwiftUI Optimisation - Githubissues

maplibre / maplibre-navigation-ios

MapLibre Navigation SDK for iOS

Other

29 stars 27 forks source link

SwiftUI Optimisation #76

Open Patrick-Kladek opened 3 days ago

Patrick-Kladek commented 3 days ago

Description

We are wrapping MapLibre-navigation in a UIViewControllerRepresentable. The updateUIViewController function is run multiple times leading to setting the same variable over and over.

Open Tasks

[x] prevent code from running again after setting the same property again
[x] only call navigationViewControllerDidFinishRouting when confirmed via button

Infos for Reviewer

michaelkirk commented 3 days ago

Hi @Patrick-Kladek - I just want to make sure that it stays focused on one issue, so that we can avoid having a far reaching PR that changes a lot of things at once. It makes it hard to test and evaluate. I see this is currently a draft. Why is that? What's the scope of this PR?

Patrick-Kladek commented 2 days ago

@michaelkirk Sure, this PR is about fixing small things we've missed in #54. It has 3 small changes, I hope you don't want me to submit 3 PRs 😅, that's why I included it here. I've already got the approval from my team, so it's ready to review here too.