search

maplibre / maplibre-react-native

A MapLibre react native module for creating custom maps
Other
252 stars 53 forks source link

Maplibre is not usable on f-droid #433

Open meypod opened 2 months ago

meypod commented 2 months ago

Hi

Since Maplibre is using https://dl.bintray.com/maplibre/maplibre-gl-native maven repo, f-droid builds are failing. I think the library should be hosted on a well-known maven repo.

related: https://gitlab.com/fdroid/fdroiddata/-/merge_requests/15592

thank you for your hard work

tyrauber commented 2 months ago

I don't even see the Android documentation adding this line?! A search for bintray.com comes up empty. I wonder if this is a legacy requirement of older versions of the SDK. Perhaps the newer SDK doesn't require it and just removing this line will work?

meypod commented 2 months ago

hi it's because it's here, in maplibre-react-native: https://github.com/maplibre/maplibre-react-native/blob/9fcf6d162b49044a3789eadc5c1d4b784444728d/android/rctmln/build.gradle#L56

meypod commented 2 months ago

@tyrauber I seem to be able to build it locally with the maven block removed, and the build works, so I guess it's a legacy requirement of maplibre-react-native ?

sorry about the mention.

tyrauber commented 2 months ago

No worries! The native SDKs have been updated significantly since the 9.0 SDKs. My guess it is probably can be removed, I just haven't got to testing it myself.

birkskyum commented 5 days ago

The latest MapLibre Native is compatible F-Droid since Android SDK v10:

meypod commented 5 days ago

As far as i remember you just need to remove the maven block mentioned and it's good to go