Increase coords consistency and clamp zoom level to numerically feasible range

terrorfisch commented 1 year ago

Clamp the integer ZoomLevel to 0..31 when converted from floating point Zoom
Restrict traversal of WorldTileCoords to supported zoom level range
Construct QuadKey with the morton_encoding crate. This change is here because the previous QuadKey depended on the ZoomLevel type.

Fixes crash from #161 by making the "backend" more robust.

Does not implemented the desired zoom limit. This is done in #180

💻 Examples

You can arbitrarily zoom in/out in the demo without panic.

🚨 Test instructions

Launch demo and start zooming :)

✔️ PR Todo

I am not satisfied with these points yet and lack the domain knowledge to proceed:

[ ] Check get_children usage in renderer
[ ] Properly handle signedness of WorldTileCoords
[ ] Check if saturation in ViewRegion::iter is the correct way to go

terrorfisch commented 1 year ago

Did you verify by running this?

Yes. Works on my Windows 10 machine.

maxammann commented 1 year ago

Format can be fixed with just fmt

nyurik commented 1 year ago

Rebased on main, and cargo fmt-ed it

maxammann commented 1 year ago

@terrorfisch I updated this to the lastest main. If you want to go over it again, then I can review this one.

Regardin the morton-encoding dependency: I think it would be nice to include the efficiency aspect (compiled down to 20 instructions) in the source code as comment.

maxammann commented 4 months ago

@terrorfisch Same here, I would still love to merge this :)

maplibre / maplibre-rs