Fix zero size crash - Githubissues

maplibre / maplibre-rs

Experimental Maps for Web, Mobile and Desktop

Apache License 2.0

1.34k stars 77 forks source link

Fix zero size crash #276

Closed terrorfisch closed 2 months ago

terrorfisch commented 1 year ago

Fixes #274

💻 Examples

Minimize the window or resize it to y==0. This previously crashed the demo.

✔️ PR Todo

[x] The are several todo!s remaining that are not handled yet because I do not understand if these cases can occure at all. It feels like failable projection inversion is only a crutch.
[x] Is the optional WindowSize member of Surface the way to go to represent a minimized/non-existing render target
[ ] Is skipping the upload system correct when the view is invalid?
[ ] Check if expect messages meet the desired format.

maxammann commented 1 year ago

Is the optional WindowSize member of Surface the way to go to represent a minimized/non-existing render target

It could be due to headless rendering or Android. Android is very specific in which order surfaces and the rendering context is initialized.

maxammann commented 12 months ago

@terrorfisch Hi! Are you still interested in pushing this forward? :) I think the conflicts should be rather easily resolvable. If not I can also assist.

maxammann commented 2 months ago

@terrorfisch I would still love to merge this :)

maxammann commented 2 months ago

maybe this is fixed by now. I upgraded winit and if ofc changed its whole API 😅

maxammann commented 2 months ago

Closing in favor of https://github.com/maplibre/maplibre-rs/pull/315