search

maplibre / maplibre-style-spec

MapLibre Style Specification & Utilities
https://maplibre.org/maplibre-style-spec/
Other
93 stars 65 forks source link

Add `vertical-perspective` projection. Clarify that `globe` is an adaptive preset. #890

Closed birkskyum closed 2 weeks ago

birkskyum commented 2 weeks ago

With the expression syntax well underway, it seems there's a clear need for adding the General Perspective projection (general-perspective) in that way that doesn't break later. It serves as a non-adaptive globe until the expression is in.

We can too clarify that the "globe" is, and will stay as, an adaptive preset that use the general-perspective and mercator projections.

Having the genereral-projection option in GL JS early can help us begin preparing for the introduction of the expressions.

Launch Checklist

codecov-commenter commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 92.73%. Comparing base (5788145) to head (8fdaf62).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #890 +/- ## ======================================= Coverage 92.73% 92.73% ======================================= Files 105 105 Lines 4683 4683 Branches 1323 1323 ======================================= Hits 4343 4343 Misses 340 340 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

HarelM commented 2 weeks ago

Let me know which PR to review first and if we can/should push this PR or the other one first.

birkskyum commented 2 weeks ago

This one is ready to merge, so we can begin making GL JS support the non-mercator high-zoom case (with floating point errors, as noted by Jakub), and simply toggling between mercator and general-perspective.

The projection expression work needs some more time.

HarelM commented 2 weeks ago

Feel free to push this forward.