Closed birkskyum closed 1 week ago
Attention: Patch coverage is 98.22785%
with 7 lines
in your changes missing coverage. Please review.
Project coverage is 92.77%. Comparing base (
8cb30d3
) to head (1b2dec0
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I think it's a big enough change to add to the changelog, even if it's only refactoring. I would also look into removing "import * from..." to finish up the cleaning. Looks great, thanks!!
The only import * as
that are left now are in test files, looping over exports or used in spyOn
I left the config files rollup/jest/eslint, but everything else is named exports. I've sometimes just mapped the name, so it's just the import line that changes, without affecting the re-exports, or other logic.
Since this is strictly only an internal change, I don't know if a changelog bullet is needed.
Launch Checklist
CHANGELOG.md
under the## main
section.