maplibre / maplibre-style-spec

MapLibre Style Specification & Utilities
https://maplibre.org/maplibre-style-spec/
Other
93 stars 65 forks source link

Named exports #904

Closed birkskyum closed 1 week ago

birkskyum commented 1 week ago

I left the config files rollup/jest/eslint, but everything else is named exports. I've sometimes just mapped the name, so it's just the import line that changes, without affecting the re-exports, or other logic.

Since this is strictly only an internal change, I don't know if a changelog bullet is needed.

Launch Checklist

codecov-commenter commented 1 week ago

Codecov Report

Attention: Patch coverage is 98.22785% with 7 lines in your changes missing coverage. Please review.

Project coverage is 92.77%. Comparing base (8cb30d3) to head (1b2dec0).

Files with missing lines Patch % Lines
src/diff.ts 92.59% 2 Missing :warning:
src/expression/compound_expression.ts 87.50% 2 Missing :warning:
src/expression/definitions/in.ts 80.00% 1 Missing :warning:
src/expression/definitions/index_of.ts 80.00% 1 Missing :warning:
src/expression/index.ts 94.11% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #904 +/- ## ========================================== - Coverage 92.79% 92.77% -0.02% ========================================== Files 105 105 Lines 4689 4677 -12 Branches 1323 1323 ========================================== - Hits 4351 4339 -12 Misses 338 338 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

HarelM commented 1 week ago

I think it's a big enough change to add to the changelog, even if it's only refactoring. I would also look into removing "import * from..." to finish up the cleaning. Looks great, thanks!!

birkskyum commented 1 week ago

The only import * as that are left now are in test files, looping over exports or used in spyOn

Screenshot 2024-11-16 at 20 29 40