search

maplibre / maplibre-style-spec

MapLibre Style Specification & Utilities
https://maplibre.org/maplibre-style-spec/
Other
93 stars 65 forks source link

Bump version to 22.0.0 #909

Closed github-actions[bot] closed 1 week ago

github-actions[bot] commented 1 week ago

Automated changes by create-pull-request GitHub action

birkskyum commented 1 week ago

@HarelM , I made this as a Major release, because of regression concerns ( #905 ). Since we distribute .mjs, .cjs and .d.ts files, I find it increasingly problematic that our test-build suite, due to Jest 29, only can check for regressions in the .cjs bundle - with the rest of the world moving to the .mjs and .d.ts.

codecov-commenter commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 92.78%. Comparing base (c5f8f8d) to head (dfc0339).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #909 +/- ## ======================================= Coverage 92.78% 92.78% ======================================= Files 107 107 Lines 4739 4739 Branches 1346 1346 ======================================= Hits 4397 4397 Misses 342 342 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

HarelM commented 1 week ago

Wasn't vertical perspective a breaking change? In any case, major here won't hurt anyone I believe...

birkskyum commented 1 week ago

@HarelM , the vertical perspective was not breaking, see https://github.com/maplibre/maplibre-style-spec/pull/890/files - it just added another new option to the enum, effectively only changing/relaxing the typings, but the existing mercator/globe options kept working as expecting.