search

maplibre / maplibre

Documents that span across multiple MapLibre projects
https://www.maplibre.org/
Creative Commons Zero v1.0 Universal
87 stars 36 forks source link

Define Branch Protection Policy MapLibre Repositories #415

Open louwers opened 1 month ago

louwers commented 1 month ago

I transfered this issue from maplibre/maputnik, which does not have branch protection set up currently (I think a PR is required, but not a review).

I was under the impression that there is a project-wide agreement that PRs should follow the four eyes principle, but aside from the repository onboarding checklist, we don't seem to have any formal policy on this. So it would be good to have a discussion.

HarelM commented 1 month ago

From my point of view, if there are not enough people who can approve the PRs then adding a branch protection is counter-productive, which is what I currently feel is the case with maputnik repo and some other repos I maintain.

louwers commented 1 month ago

I transferred the issue so we can have a discussion about this. Maybe it would be good to have a policy on this. Tagging @ramyaragupathy and @nyurik.

Personally I think the four eyes principle is a good principle to follow in general. And I think there's always someone available for a review, although in some cases not right away.

HarelM commented 1 month ago

My experience maintaining a few of the less popular repos here is that this is not the case, and in some cases I was not able to find someone to review my PRs in a decent time period (a week). I'm not saying I couldn't get someone to approve the PR, but that's different than a review from someone who knows the code. This is especially true if for some reason there was a bug introduced in a PR someone sent and I needed to push a fix to it. I generally am in favor of a review, and I respect code review a lot, but forcing it in some places might not be the right solution.