search

maplibre / maputnik

An open source visual editor for the 'MapLibre Style Specification'
https://www.maplibre.org/maputnik
MIT License
2.14k stars 402 forks source link

Refactor driver for E2E #843

Closed HarelM closed 11 months ago

HarelM commented 11 months ago

This is basically the content of #841 with the code review changes and relevant fixes to tests/driver code to pass the tests. CC: @ShellyDCMS

After this we should lint the project and add the lint to the CI to make sure it doesn't break.

codesandbox-ci[bot] commented 11 months ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 466b8e667accd9d9c6acb450a5054ef6f114dba1:

Sandbox Source
maputnik Configuration
HarelM commented 11 months ago

Hmm... Seems like "skip link to layer editor" test doesn't want to pass on chrome when running in CI. When I run it locally it does pass both from CMD and from Cypress UI. Not sure what to do here...

HarelM commented 11 months ago

Merging this to continue development. If the test will continue to be ignored, we'll remove it eventually. @nyurik Now might be a good time to push the lint fixes