search

maplibre / maputnik

An open source visual editor for the 'MapLibre Style Specification'
https://www.maplibre.org/maputnik
MIT License
2.14k stars 402 forks source link

Migration of jsx files to tsx 3 #851

Closed HarelM closed 11 months ago

HarelM commented 11 months ago

This is in continue to:

The last files should be converted as part of this PR, there are only a handful left.

codesandbox-ci[bot] commented 11 months ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 6975bf29c7faa37abd9129371104774e0c91ef5d:

Sandbox Source
maputnik Configuration
HarelM commented 11 months ago

That was fast. Do you prefer that I open a new PR or pile the rest of the files as part of this PR?

nyurik commented 11 months ago

its ok if they are very similar to this change to push them here and squash them after

HarelM commented 11 months ago

Ok, I'll push them here then, the changes are mainly to add types and rename the files. It shouldn't take more than a few work hours to finish this.

HarelM commented 11 months ago

This is now ready for review. I have completed the migration. It's not perfect, but it's a lot better than before. I also fixed some console errors and warnings. I'm not an experienced Maputnik user, so this probably needs some more testing before it can be released.

As far as I could tell the release process is by building it in this repo and copying the files to the maputnik.io repo. It might be a good idea to maybe create an npm package with the build outputs to allow versioning.

Lint and code coverage are probably the next steps, and later on packages upgrade when the coverage is OK, or if someone can define a way to make sure the build is OK manually.