maplibre / maputnik

An open source visual editor for the 'MapLibre Style Specification'
https://www.maplibre.org/maputnik
MIT License
2.02k stars 380 forks source link

Add lint to CI and fix errors #853

Closed HarelM closed 6 months ago

HarelM commented 6 months ago

Adds lint to CI and fixes errors. I'm not sure I'm fully proud of all the solutions there. But there's no lint issues and the lint is being checked as part of the CI.

codesandbox-ci[bot] commented 6 months ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 72bb15ec6d4355620d3b40340c5e8ae0049ec4c2:

Sandbox Source
maputnik Configuration
codecov-commenter commented 6 months ago

Codecov Report

Attention: 54 lines in your changes are missing coverage. Please review.

Comparison is base (a324ddb) 56.71% compared to head (72bb15e) 56.81%.

Files Patch % Lines
src/libs/apistore.ts 0.00% 12 Missing :warning:
src/components/ModalSources.tsx 58.33% 5 Missing :warning:
src/components/App.tsx 73.33% 4 Missing :warning:
src/components/MapMaplibreGlLayerPopup.tsx 20.00% 4 Missing :warning:
src/components/ModalOpen.tsx 80.00% 3 Missing :warning:
src/components/_ExpressionProperty.tsx 0.00% 3 Missing :warning:
src/libs/metadata.ts 70.00% 3 Missing :warning:
src/libs/urlopen.ts 57.14% 3 Missing :warning:
src/util/codemirror-mgl.ts 0.00% 3 Missing :warning:
src/components/IconLayer.tsx 33.33% 2 Missing :warning:
... and 8 more

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #853 +/- ## ========================================== + Coverage 56.71% 56.81% +0.09% ========================================== Files 104 104 Lines 2932 2929 -3 Branches 674 674 ========================================== + Hits 1663 1664 +1 + Misses 1269 1265 -4 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.