search

maplibre / maputnik

An open source visual editor for the 'MapLibre Style Specification'
https://www.maplibre.org/maputnik
MIT License
2.02k stars 380 forks source link

Improve tests #854

Closed HarelM closed 6 months ago

HarelM commented 6 months ago

Recover commented out tests, Improve usage of helper in driver, Added data-wd-key for test to use instead of classes Moved all non tsx file to a single folder (lib) instead of lib and utils

codesandbox-ci[bot] commented 6 months ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 5235ef8838dc9c3311a984bedbaa12df14aec043:

Sandbox Source
maputnik Configuration
codecov-commenter commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (09a1f3f) 56.77% compared to head (5235ef8) 57.18%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #854 +/- ## ========================================== + Coverage 56.77% 57.18% +0.40% ========================================== Files 104 104 Lines 2929 2929 Branches 674 674 ========================================== + Hits 1663 1675 +12 + Misses 1266 1254 -12 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

HarelM commented 6 months ago

Thanks @nyurik!! You are working in weird hours... :-D