maplibre / maputnik

An open source visual editor for the 'MapLibre Style Specification'
https://www.maplibre.org/maputnik
MIT License
2.02k stars 380 forks source link

E2E: Improve tests, lint, and add more drivers #855

Closed HarelM closed 6 months ago

HarelM commented 6 months ago

This PR introduces lint to cypress code, adds drivers to try and abstract the usage of cypress as much as possible. Nothing very interesting, mainly to try out the driver pattern for the e2e tests.

codesandbox-ci[bot] commented 6 months ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit a3c40ef2488d75373b770c7c281225ef5311df77:

Sandbox Source
maputnik Configuration
codecov-commenter commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (b784bf2) 57.18% compared to head (a3c40ef) 57.25%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #855 +/- ## ========================================== + Coverage 57.18% 57.25% +0.06% ========================================== Files 104 104 Lines 2929 2929 Branches 674 674 ========================================== + Hits 1675 1677 +2 + Misses 1254 1252 -2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.