search

maplibre / maputnik

An open source visual editor for the 'MapLibre Style Specification'
https://www.maplibre.org/maputnik
MIT License
2.02k stars 380 forks source link

improve drivers #856

Closed ShellyDCMS closed 6 months ago

ShellyDCMS commented 6 months ago

@HarelM , can you please push a lockfile? Even when creating a lockfile with codespaces the build fails

HarelM commented 6 months ago

My codespaces account is maxed out for this month... :-/ What steps are you doing to generate the lock file in codespaces? I think the following should work:

  1. nvm install to get the right node version
  2. npm install
  3. Push the lock file.

Did you try that? You can also run npm ci to check that the lock file is correct.

ShellyDCMS commented 6 months ago

@HarelM , I delete the lock file, I delete node modules I run npm i Can you try locally maybe?

codesandbox-ci[bot] commented 6 months ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 6650262d2671629b703f0adbb8b1d67da0b6fb88:

Sandbox Source
maputnik Configuration
HarelM commented 6 months ago

I did the above with the addition of npm cache clean --force to avoid any local cache issues. I also removed the cache part of the build which I don't think is necessary...

codecov-commenter commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (124ae98) 57.18% compared to head (6650262) 57.15%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #856 +/- ## ========================================== - Coverage 57.18% 57.15% -0.04% ========================================== Files 104 104 Lines 2929 2929 Branches 674 674 ========================================== - Hits 1675 1674 -1 - Misses 1254 1255 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

HarelM commented 6 months ago

Layes tests were a bit hard to review, I hope it's similar as I was not able to fully compare one test to the other. Generally speaking this looks great! THANKS!

HarelM commented 6 months ago

I really need to find a way to fix this lint rule for the switch case... :-/ I also like 4 spaces and not 2. out of scope for this PR...