maplibre / maputnik

An open source visual editor for the 'MapLibre Style Specification'
https://www.maplibre.org/maputnik
MIT License
2.14k stars 402 forks source link

Inspect's popup truncates the property values #868

Closed zstadler closed 9 months ago

zstadler commented 10 months ago

Maputnik version: v2.0.0-pre.2 Browser: All OS: All

Description of the bug: The Inspect's popup does not show much of the properties values. Instead, there is a large gap between the property name and the value.

Steps to reproduce the behavior:

  1. Open any style with a vector source, such as the pre-loaded "OSM Liberty" style
  2. Change to Inspect view
  3. Move the mouse around the map

Screenshots: image

HarelM commented 10 months ago

This is probably related to some css issues. Can you provide a screen shot of the same place in 1.7 (previous maputnik website)? I also think the is a problem with the modal dialog widths.

zstadler commented 10 months ago

The 1.7.0 version looks better, but still needs a CSS improvement to reduce the empty gap and increase the width of the values column:

image

I also believe that in 2.0.0 it is not just a CSS issue. The 1.7.0 row structure is straight forward:

image

The 2.0.0 row structure has

image

For our reference, here are the footprints of the yellow elements:

HarelM commented 10 months ago

I've seen this block stuff in the code, it's very confusing to understand and see where a block wraps another block... You should be able to workaroud this locally by changing some css class in the browser itself. Never the less, this needs fixing...

zstadler commented 10 months ago

It is not clear to me why <input ...> is used for the values column, as values it contains cannot be changed.

This may or may not be causing some small vertical offset between the two columns:

image

I believe this pop-up would be better off as simple table with same formatting for both columns, where the tags use just 30% of the width.