search

maplibre / maputnik

An open source visual editor for the 'MapLibre Style Specification'
https://www.maplibre.org/maputnik
MIT License
2.02k stars 380 forks source link

Removes number conversion for dirty input #878

Closed HarelM closed 4 months ago

HarelM commented 5 months ago

Fixes #870

This regression bug was introduced as part of the refactoring of typescript. Here:

I've added tests to cover the scenario so that it won't happen again, hopefully.

codecov-commenter commented 5 months ago

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (c84c7a7) 56.80% compared to head (4015f63) 57.17%.

Files Patch % Lines
src/components/InputNumber.tsx 33.33% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #878 +/- ## ========================================== + Coverage 56.80% 57.17% +0.37% ========================================== Files 104 104 Lines 2940 2940 Branches 670 670 ========================================== + Hits 1670 1681 +11 + Misses 1270 1259 -11 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

HarelM commented 4 months ago

I'm merging this as this is a critical bug. @birkskyum @nyurik feel free to add comments here and I'll open a different PR to solve them.