maplibre / maputnik

An open source visual editor for the 'MapLibre Style Specification'
https://www.maplibre.org/maputnik
MIT License
2.02k stars 380 forks source link

Improve inspect hover UI #879

Closed HarelM closed 4 months ago

HarelM commented 5 months ago

Fixes #868

It solves all the block within blocks and all kind of controls that are not required which creates gaps. I use a simple table, so the width is dynamic but it is always aligned for all the properties and the features. image

Vary basic stuff. There's still the layer popup, which I'm not sure I know what it is and might need to be fixed as well. CC: @zstadler

codecov-commenter commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (c84c7a7) 56.80% compared to head (285dca8) 56.86%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #879 +/- ## ========================================== + Coverage 56.80% 56.86% +0.05% ========================================== Files 104 104 Lines 2940 2937 -3 Branches 670 670 ========================================== Hits 1670 1670 + Misses 1270 1267 -3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

zstadler commented 5 months ago

Thanks!

From some experiments I've done, hacking the previous css in the browser, a 30% width for the property name would

HarelM commented 4 months ago

I've updated the code, css etc, it uses a HTML table now which I think is what is the expectations here. I haven't specified the width, so it's fully dynamic now, the default is 50%, but it will change according to the values in the table.