search

maplibre / maputnik

An open source visual editor for the 'MapLibre Style Specification'
https://www.maplibre.org/maputnik
MIT License
2.08k stars 397 forks source link

unable to upload style #880

Closed liyoung47 closed 7 months ago

liyoung47 commented 7 months ago

Maputnik version:v2.0.0 Browser:Firefox, Chrome OS:macOS

Description of the bug: We've used Maputnik for years to examine our custom styles, but just recently it has stopped working. When we upload our custom style file, the map does not change to show the new style, even tho the left-hand panel shows the names of the layers from the new style

Steps to reproduce the behavior:

  1. launch Chrome incognito (to be sure of a fresh start) and visit https://maplibre.org/maputnik. OSM Liberty is displayed by default
  2. choose Open > Upload and select local json style file

expected: new style is displayed actual: the layers in the left bar reflect the local json style, but OSM Liberty is still displayed on the map.

Style file or style URL: I'm not able to share our style files, but the identical style files worked as recently as a few weeks ago, and are still working in our client apps with regular maplibre.

Screenshots: video: attempt to upload style, from fresh state: https://github.com/maplibre/maputnik/assets/5832047/089a4e37-f286-4265-8881-f073138ff983

HarelM commented 7 months ago

Can you check if this is the same issue as: #871 i.e. if you refresh the browser after you load the style it will work?

liyoung47 commented 7 months ago

When I refresh the browser after upload, the map looks like what I was expecting.

in #871 they went from an uploaded style to a built-in style and saw a merged result. When I go from the uploaded style (which I only get after refreshing) to the built-in style, the built-in style looks fine.

I was able to get into a merged state earlier...I took screenshots but have not been able get into this state again. following the steps in #871 has not produced it

map with merged state: square is OSM Liberty, rest is uploaded style

merged style

inspection with merged state: the source "omv: water" is from my style, the "openmaptiles: transportation" is from one of the built-in styles as my style has no source with that name

merged style inspection
HarelM commented 7 months ago

I believe it's similar, the direction is not part of the problem, but the "merge" state. I can keep the issue open, but I believe it's the same if refreshing the browser solves the issue.

liyoung47 commented 7 months ago

I don't mind if you want to close if you think its a duplicate. If I'm able to replicate the merged state again I'll check and see if refreshing fixes it.

HarelM commented 7 months ago

Closing as duplicate of #871. I'll gladly reopen if this is not the same once the other issue is fixed.