maplibre / maputnik

An open source visual editor for the 'MapLibre Style Specification'
https://www.maplibre.org/maputnik
MIT License
2.02k stars 380 forks source link

Readme.md container port changed to 80 #881

Closed glebpinigin closed 4 months ago

glebpinigin commented 4 months ago

Activating maputnik with docker run requires to bind port 80 from container and not 8888, because nginx is running with default config and listening port 80

For npm run port 8888 is explicitly set up in config.

codecov-commenter commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (bc5ecfa) 57.17% compared to head (38f1183) 57.17%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #881 +/- ## ======================================= Coverage 57.17% 57.17% ======================================= Files 104 104 Lines 2940 2940 Branches 670 670 ======================================= Hits 1681 1681 Misses 1259 1259 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

HarelM commented 4 months ago

Thanks!