maplibre / maputnik

An open source visual editor for the 'MapLibre Style Specification'
https://www.maplibre.org/maputnik
MIT License
2.02k stars 380 forks source link

localIdeographFontFamily: false to load CJK fonts #893

Closed Kanahiro closed 3 months ago

Kanahiro commented 3 months ago

close #892

this changes works well for CJK fonts.

Screenshot 2024-03-25 at 22 04 36
HarelM commented 3 months ago

What would this change do to latin characters? Will they still be using the glyphs? Also worth opening a PR for maplibre-gl to fix the type of the variable.

Kanahiro commented 3 months ago

@HarelM Thank you for checking this PR. This change seems to make no change on latin characters for me.

HarelM commented 3 months ago

Let's use this PR to update maplibre-gl to avoid introducing "as any", it should be a few days at max.

HarelM commented 3 months ago

4.1.2 should be available now. Let me know if it solves the as any part.

Kanahiro commented 3 months ago

@HarelM Thank you for supporting! I've fixed.

HarelM commented 3 months ago

Should be published in a few minutes, let me know if you encounter any issue with this.