search

maplibre / ngx-maplibre-gl

Angular binding of maplibre-gl
https://maplibre.org/ngx-maplibre-gl/
MIT License
72 stars 25 forks source link

Decouple driver from Cypress, use Assertable #134

Closed ShellyDCMS closed 8 months ago

ShellyDCMS commented 8 months ago

Test Refactoring

  1. All assertions are in the test rather than in the driver
  2. separate give, when and get
  3. use then and Assertable
  4. use CypressHelper for decoupling from Cypress
HarelM commented 8 months ago

I can't tell which comments were addressed and which weren't. I'm leaving it to you to find out. Overall this looks great but it's hard to review due to all the extra noise... Thanks!