feat(mgl-marker): add input for rotation

maplibre / ngx-maplibre-gl

Angular binding of maplibre-gl

https://maplibre.org/ngx-maplibre-gl/

MIT License

65 stars 25 forks source link

feat(mgl-marker): add input for rotation #148

Closed ctaepper closed 3 months ago

ctaepper commented 3 months ago

fixes #147

HarelM commented 3 months ago

Thanks! looks good. Did you test that it works?

ctaepper commented 3 months ago

honestly - no... it was absolutely straight forward and I don't have my "work setup" at home

ctaepper commented 3 months ago

placeholder image from placekitten.com is currently broken (remote server error). thats why e2e tests are failing

HarelM commented 3 months ago

Would be great if you could do a minimal test, maybe hack a showcase page to make sure this is working as expected? I would sleep a lot better at night :-)

ctaepper commented 3 months ago

you are right, here you go

HarelM commented 3 months ago

Any chance you can fix the e2e tests to use local image, or whatever is needed for this to pass?

ctaepper commented 3 months ago

on its way. should go green now