mapmanager / MapManagerCore

A Python library with the core functionality of MapManager
0 stars 0 forks source link

`getShapePixels` should not clip bounds by default #20

Open Suhayb-A opened 4 months ago

Suhayb-A commented 4 months ago

Shapes that are out of the image bounds should be filled with np.nan instead of clipping to the bounds of the image. I am opening a case since this might not be necessary if it is handled at a higher level (see #19).

This also relates to computing background ROI offsets. Optimally, the grid should remove all invalid offsets before calling getShapePixels, alternatively one can call getShapePixels and then drop nan values if getShapePixels returns np.nan where an image is out of bounds.