Closed goergen95 closed 7 months ago
Attention: 1 lines
in your changes are missing coverage. Please review.
Comparison is base (
70157bb
) 73.31% compared to head (4fd992c
) 74.40%. Report is 1 commits behind head on main.
Files | Patch % | Lines |
---|---|---|
R/calc_indicators.R | 95.00% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Sorry, I saw your request too late. I'm testing on my data right now that caused the problem in the first place.
@goergen95 I think the original problem is solved, but it's still failing for me because the calc_landcover function returns zero-length tibbles instead of NAs. I'm currently going through my data to identify a reproducible example
But shouldn't that be covered for with 87b99ba8?
I don't have the original error anymore, because my session crashed. But I think I received the new error message from calc_indicators
: https://github.com/mapme-initiative/mapme.biodiversity/blob/87b99ba8de68c05be1f5b525b5501e51515793ae/R/calc_indicators.R#L212-L215
This would mean that the landcover indicator returned a zero-length tibble. That's my guess at least. I'm still looking for the offending polygon.
Oh, I see what you mean now. So there is a bug in the landcover function that is not directly related to this PR.
You're right, I'll add it as an issue, I managed to find a reprex now, too.
Hi, I this fixes the issue, I think. Would you mind to check? I also tried to make the code more understandable. Maybe let's have a discussion about the assumptions used here?