Closed goergen95 closed 6 months ago
Attention: 3 lines
in your changes are missing coverage. Please review.
Comparison is base (
755cd8b
) 74.68% compared to head (1363da9
) 74.71%.
Files | Patch % | Lines |
---|---|---|
R/calc_indicators.R | 89.47% | 2 Missing :warning: |
R/get_resources.R | 92.85% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Are there any objections to merging this @karpfen and @Jo-Schie?
I personally think this is the cleaner approach. However I just want to raise the attention that you might need to update the documentation if the tile-index is used somewhere...
Instead of writing the tileindex for raster resources to disk (which actually requires reading them from disk for every asset) the tile-indices are now added to a portfolio as an
sf
object directly. This omits reading from disk, but also requires to runget_resources()
for each resource that is required because theadd_resource
argument toinit_portfolio()
no longer makes sense. This argument, however, has caused more confusion (see e.g. #91 and #92) than providing benefit so it seems ok to deprecate it.