mapme-initiative / mapme.biodiversity

Efficient analysis of spatial biodiversity datasets for global portfolios
https://mapme-initiative.github.io/mapme.biodiversity/
GNU General Public License v3.0
24 stars 7 forks source link

add resource documentation for Global Surface Water #239

Closed karpfen closed 4 months ago

karpfen commented 4 months ago

This PR adds the missing GSW documentation, s. https://github.com/mapme-initiative/mapme.biodiversity/issues/234

goergen95 commented 4 months ago

Hi @karpfen, thanks! I think this also applies to the indicators. Would you mind revising them as well and include it in this PR?

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (979edec) 75.33% compared to head (40e7726) 75.33%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #239 +/- ## ======================================= Coverage 75.33% 75.33% ======================================= Files 49 49 Lines 1845 1845 ======================================= Hits 1390 1390 Misses 455 455 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

karpfen commented 4 months ago

@goergen95 I added the calcgsw* function docs now.

karpfen commented 4 months ago

I just found a typo, I'll fix it before the merge

karpfen commented 4 months ago

Typo is now fixed.

karpfen commented 4 months ago

Thanks for the hints, @goergen95, should be good now.

For the conversion between water occurrence -> water area I'll talk to WiWe and implement it in a different PR depending on their requirements. I'll just add a new issue for it now.