search

mapme-initiative / mapme.biodiversity

Efficient analysis of spatial biodiversity datasets for global portfolios
https://mapme-initiative.github.io/mapme.biodiversity/
GNU General Public License v3.0
24 stars 7 forks source link

Improved UI using closures #252

Closed goergen95 closed 2 months ago

goergen95 commented 3 months ago

This PR is bound to be merged towards end of April 2024 as detailed in #240.

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 84.46735% with 226 lines in your changes are missing coverage. Please review.

Project coverage is 83.24%. Comparing base (f2f00cc) to head (1e31dcb).

Files Patch % Lines
R/get_fritz_et_al.R 39.47% 23 Missing :warning:
R/get_worldpop.R 33.33% 22 Missing :warning:
R/get_soilgrids.R 52.27% 21 Missing :warning:
R/get_nasa_firms.R 62.22% 17 Missing :warning:
R/get_teow.R 34.61% 17 Missing :warning:
R/register.R 81.48% 15 Missing :warning:
R/get_ucdp_ged.R 57.14% 12 Missing :warning:
R/calc_indicators.R 87.14% 9 Missing :warning:
R/calc_precipitation_chirps.R 91.56% 7 Missing :warning:
R/calc_treecover_area_and_emissions.R 83.33% 7 Missing :warning:
... and 26 more
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #252 +/- ## ========================================== + Coverage 75.87% 83.24% +7.37% ========================================== Files 49 50 +1 Lines 1886 2095 +209 ========================================== + Hits 1431 1744 +313 + Misses 455 351 -104 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

goergen95 commented 3 months ago

hi @karpfen, I think we should merge this ASAP, so that when people hit the default branch, e.g. via remotes::install_github("mapme-initiative/mapme.biodiversity") they install the latest version. Will keep it only on main until end of April, the release it to CRAN. Would you have any objections to that approach?

karpfen commented 3 months ago

Hi @goergen95 woah, nice work! Yes, I think that's a good way to go. I only had a brief glance at the code now, though. I didn't come across anything major yet, but I'd definitely like to remove all native R pipes for now and replace them with magrittr style pipes. I've already changed it, just waiting for my local checks to finish before I push it.

goergen95 commented 3 months ago

In case you want to peek at the rendered online documentation you can download a artifact on the summary page of the pkgdown action (for the current run this is found here).

goergen95 commented 3 months ago

Found additional note: 

Found the following (possibly) invalid URLs:
  URL: https://www.worldwildlife.org/publications/terrestrial-ecoregions-of-the-world
    From: man/teow.Rd
    Status: 403
    Message: Forbidden

but that seems to be a false positive.

goergen95 commented 2 months ago

merging this now so that users landing on GitHub find the new version. This is bound to be sent to CRAN towards end of April.