search

mapnik / Cascadenik

Cascading Sheets Of Style for Mapnik
http://github.com/mapnik/Cascadenik/wiki/Cascadenik
BSD 3-Clause "New" or "Revised" License
111 stars 20 forks source link

display:none preprocessor #19

Open nvkelso opened 12 years ago

nvkelso commented 12 years ago

For situations where there is CSS for a class, but the end result is NULL in terms of drawing anything (like line-opacity: 0; where there is no other symbology applied), the data layer should be turned off and the CSS skipped.

rcoup commented 12 years ago

so special-case 0 for width and opacity and shortcut the symbolizer creation? Any others that spring to mind?

nvkelso commented 12 years ago

Seems like it should apply to all:

stroke-opacity polygon-opacity line-width outline-width inline-width outline-opacity inline-opacity point-width point-height line-pattern-width line-pattern-height shield-size

On Mon, Oct 31, 2011 at 17:22, Robert Coup < reply@reply.github.com>wrote:

so special-case 0 for width and opacity and shortcut the symbolizer creation? Any others that spring to mind?

Reply to this email directly or view it on GitHub: https://github.com/mapnik/Cascadenik/issues/19#issuecomment-2585343

migurski commented 12 years ago

I've gotten display: none working, here's the test on the branch: https://github.com/mapnik/Cascadenik/blob/16afc57c/cascadenik/tests.py#L2065

The opposite of display: none is display: map, and it’s implied for all elements.

I can likely make lines of zero width and so one work as described above too.

nvkelso commented 12 years ago

Awesome!

_n

On Fri, May 4, 2012 at 5:10 PM, migurski < reply@reply.github.com

wrote:

I've gotten display: none working, here's the test on the branch: https://github.com/mapnik/Cascadenik/blob/16afc57c/cascadenik/tests.py#L2065

The opposite of display: none is display: map, and it’s implied for all elements.

I can likely make lines of zero width and so one work as described above too.

Reply to this email directly or view it on GitHub: https://github.com/mapnik/Cascadenik/issues/19#issuecomment-5522779

nvkelso commented 12 years ago

Is this closed now?

migurski commented 12 years ago

The special-case 0 is still open.